feat(material-experimental/mdc-form-field): expose MAT_FORM_FIELD injection token - #19277
Merged
jelbourn merged 1 commit intoMay 7, 2020
Conversation
…njection token We recently added a new injection token called `MAT_FORM_FIELD`. This token should allow form control implementers to inject the form-field without having to bring in the actual `MatFormField` as a side-effect. We should expose that token from the MDC form-field entry-point too, as that will ease the migration. Also it would be unexpected if an application switches to the MDC-based form field, but would still need to import from the non-MDC form field entry-point.
jelbourn
pushed a commit
that referenced
this pull request
May 7, 2020
…njection token (#19277) We recently added a new injection token called `MAT_FORM_FIELD`. This token should allow form control implementers to inject the form-field without having to bring in the actual `MatFormField` as a side-effect. We should expose that token from the MDC form-field entry-point too, as that will ease the migration. Also it would be unexpected if an application switches to the MDC-based form field, but would still need to import from the non-MDC form field entry-point.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We recently added a new injection token called
MAT_FORM_FIELD. Thistoken should allow form control implementers to inject the form-field
without having to bring in the actual
MatFormFieldas a side-effect.We should expose that token from the MDC form-field entry-point too,
as that will ease the migration. Also it would be unexpected if an
application switches to the MDC-based form field, but would still need
to import from the non-MDC form field entry-point.