Skip to content

fix(cdk/scrolling): support multiple items per row #29453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
reboot25 wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix(cdk/scrolling): support multiple items per row #29453

reboot25 wants to merge 3 commits into from

Conversation

@reboot25
Copy link

@reboot25 reboot25 commented Jul 18, 2024

Add virtual scroll support to multiple columns per row. The viewport will list items with flex-wrap styles, and the width of each item has two types of values: fixed pixel and percentage. For example, {width: 200, height: 50} and {width: '25%', height: 50}.

Fixes #10114

@reboot25
fix(cdk/scrolling): support multiple items per row
477a418 
Add virtual scroll support to multiple columns per row. The viewport will list items with flex-wrap styles, and the width of each item has two types of values: fixed pixel and percentage. For example, {width: 200, height: 50} and {width: '25%', height: 50}.

Fixes angular#10114
@reboot25 reboot25 requested a review from a team as a code owner July 18, 2024 09:09
@reboot25 reboot25 requested review from amysorto and crisbeto and removed request for a team July 18, 2024 09:09
@crisbeto crisbeto requested a review from mmalerba July 18, 2024 09:11
@reboot25
Copy link
Author

reboot25 commented Jul 18, 2024 •
edited
Loading

How to fix this check? https://github.com/angular/components/actions/runs/9988750555/job/27606001968
Is this the file need to be updated as well? https://github.com/reboot25/components/blob/multi-columns-virtual-scroll/tools/public_api_guard/cdk/scrolling.md

@crisbeto
Copy link
Member

crisbeto commented Jul 18, 2024

You have to run yarn approve-api cdk/scrolling and commit the changed file.

@reboot25
Copy link
Author

reboot25 commented Jul 18, 2024

You have to run yarn approve-api cdk/scrolling and commit the changed file.

Thanks, I have updated the file

@schreibse
Copy link

schreibse commented Feb 15, 2025

any update on this PR?

@mmalerba mmalerba removed their request for review February 20, 2025 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@crisbeto crisbeto Awaiting requested review from crisbeto crisbeto was automatically assigned from angular/components-googlers

@amysorto amysorto Awaiting requested review from amysorto amysorto was automatically assigned from angular/components-googlers

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

virtual-scroll: support multiple items per row

3 participants

@reboot25 @crisbeto @schreibse