-
Notifications
You must be signed in to change notification settings - Fork 6.8k
refactor(cdk-experimental/radio-group): use shared example classes #31496
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Deployed dev-app for b174b7f to: https://ng-dev-previews-comp--pr-angular-components-31496-dev-n2vwe80a.web.app Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR refactors the CDK experimental radio-group examples to leverage shared example utility classes, removing duplicated CSS rules and unifying markup across all examples.
- Stripped out custom stateful and disabled selectors from
radio-common.css
in favor of centralized shared example classes. - Updated each radio-group example HTML to add
.example-parent
on the container and.example-stateful
/.example-selectable
on each radio button.
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
File | Description |
---|---|
src/components-examples/cdk-experimental/radio-group/radio-common.css | Removed duplicated stateful/disabled CSS rules now provided by shared example classes. |
src/components-examples/cdk-experimental/radio-group/cdk-radio-group-standard/.../example.html | Added .example-parent to <ul> and .example-stateful , .example-selectable to <li> . |
src/components-examples/cdk-experimental/radio-group/cdk-radio-group-readonly/.../example.html | Added .example-parent to <ul> and .example-stateful , .example-selectable to <li> . |
src/components-examples/cdk-experimental/radio-group/cdk-radio-group-horizontal/.../example.html | Added .example-parent to <ul> and .example-stateful , .example-selectable to <li> . |
src/components-examples/cdk-experimental/radio-group/cdk-radio-group-disabled/.../example.html | Added .example-parent to <ul> and .example-stateful , .example-selectable to <li> . |
src/components-examples/cdk-experimental/radio-group/cdk-radio-group-disabled-skipped/.../example.html | Added .example-parent to <ul> and .example-stateful , .example-selectable to <li> . |
src/components-examples/cdk-experimental/radio-group/cdk-radio-group-disabled-focusable/.../example.html | Added .example-parent to <ul> and .example-stateful , .example-selectable to <li> . |
src/components-examples/cdk-experimental/radio-group/cdk-radio-group-configurable/.../example.html | Added .example-parent to <ul> and .example-stateful , .example-selectable to <li> . |
src/components-examples/cdk-experimental/radio-group/cdk-radio-group-active-descendant/.../example.html | Added .example-parent to <ul> and .example-stateful , .example-selectable to <li> . |
Comments suppressed due to low confidence (2)
src/components-examples/cdk-experimental/radio-group/radio-common.css:25
- The background-color rule for disabled
.example-radio-group
was removed; ensure the shared utility classes include equivalent styling so disabled groups remain visually distinguishable.
.example-radio-group[aria-disabled='true'] {
src/components-examples/cdk-experimental/radio-group/radio-common.css:77
- The opacity reduction for disabled radio button text was removed; verify that the shared example classes apply a clear disabled-state visual indicator for readability.
}
.../cdk-experimental/radio-group/cdk-radio-group-standard/cdk-radio-group-standard-example.html
Show resolved
Hide resolved
155f3d2
to
b174b7f
Compare
No description provided.