Skip to content

refactor(cdk-experimental/radio-group): use shared example classes #31496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 8, 2025

Conversation

wagnermaciel
Copy link
Contributor

No description provided.

@wagnermaciel wagnermaciel requested a review from a team as a code owner July 7, 2025 22:00
@wagnermaciel wagnermaciel requested review from crisbeto and andrewseguin and removed request for a team July 7, 2025 22:00
@wagnermaciel wagnermaciel added target: minor This PR is targeted for the next minor release dev-app preview When applied, previews of the dev-app are deployed to Firebase labels Jul 7, 2025
Copy link

github-actions bot commented Jul 7, 2025

Deployed dev-app for b174b7f to: https://ng-dev-previews-comp--pr-angular-components-31496-dev-n2vwe80a.web.app

Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt.

@wagnermaciel wagnermaciel requested a review from Copilot July 8, 2025 15:12
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the CDK experimental radio-group examples to leverage shared example utility classes, removing duplicated CSS rules and unifying markup across all examples.

  • Stripped out custom stateful and disabled selectors from radio-common.css in favor of centralized shared example classes.
  • Updated each radio-group example HTML to add .example-parent on the container and .example-stateful/.example-selectable on each radio button.

Reviewed Changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/components-examples/cdk-experimental/radio-group/radio-common.css Removed duplicated stateful/disabled CSS rules now provided by shared example classes.
src/components-examples/cdk-experimental/radio-group/cdk-radio-group-standard/.../example.html Added .example-parent to <ul> and .example-stateful, .example-selectable to <li>.
src/components-examples/cdk-experimental/radio-group/cdk-radio-group-readonly/.../example.html Added .example-parent to <ul> and .example-stateful, .example-selectable to <li>.
src/components-examples/cdk-experimental/radio-group/cdk-radio-group-horizontal/.../example.html Added .example-parent to <ul> and .example-stateful, .example-selectable to <li>.
src/components-examples/cdk-experimental/radio-group/cdk-radio-group-disabled/.../example.html Added .example-parent to <ul> and .example-stateful, .example-selectable to <li>.
src/components-examples/cdk-experimental/radio-group/cdk-radio-group-disabled-skipped/.../example.html Added .example-parent to <ul> and .example-stateful, .example-selectable to <li>.
src/components-examples/cdk-experimental/radio-group/cdk-radio-group-disabled-focusable/.../example.html Added .example-parent to <ul> and .example-stateful, .example-selectable to <li>.
src/components-examples/cdk-experimental/radio-group/cdk-radio-group-configurable/.../example.html Added .example-parent to <ul> and .example-stateful, .example-selectable to <li>.
src/components-examples/cdk-experimental/radio-group/cdk-radio-group-active-descendant/.../example.html Added .example-parent to <ul> and .example-stateful, .example-selectable to <li>.
Comments suppressed due to low confidence (2)

src/components-examples/cdk-experimental/radio-group/radio-common.css:25

  • The background-color rule for disabled .example-radio-group was removed; ensure the shared utility classes include equivalent styling so disabled groups remain visually distinguishable.
.example-radio-group[aria-disabled='true'] {

src/components-examples/cdk-experimental/radio-group/radio-common.css:77

  • The opacity reduction for disabled radio button text was removed; verify that the shared example classes apply a clear disabled-state visual indicator for readability.
}

@andrewseguin andrewseguin added the action: merge The PR is ready for merge by the caretaker label Jul 8, 2025
@wagnermaciel wagnermaciel removed the request for review from crisbeto July 8, 2025 17:37
@wagnermaciel wagnermaciel merged commit 12c6b08 into angular:main Jul 8, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action: merge The PR is ready for merge by the caretaker dev-app preview When applied, previews of the dev-app are deployed to Firebase target: minor This PR is targeted for the next minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants