Skip to content

fix(console): publish desktop theme schema - #43203

Closed
OpeOginni wants to merge 2 commits into
anomalyco:devfrom
OpeOginni:publish-desktop-schema
Closed

OpeOginni wants to merge 2 commits into
anomalyco:devfrom
OpeOginni:publish-desktop-schema

Conversation

@OpeOginni

Copy link
Copy Markdown
Contributor

Issue for this PR

Type of change

  • Bug fix
  • New feature
  • Refactor / code improvement
  • Documentation

What does this PR do?

  • Publishes the desktop theme schema as /desktop-theme.json during the console build.
  • Matches the schema URL used by desktop custom themes.

How did you verify your code works?

  • Ran bun run build from packages/console/app.
  • Confirmed the generated desktop-theme.json matches the source schema.

Checklist

  • I have tested my changes locally
  • I have not included unrelated changes in this PR

@neriousy

Copy link
Copy Markdown
Member

Shouldn't this point at the file inside repo rather than hosted? Like people who have the repo cloned would be using the desktop schema stuff - hosting it on the website seems off for me

"$schema": "../desktop-theme.schema.json"

@OpeOginni

OpeOginni commented Aug 18, 2026 •

Copy link
Copy Markdown
Contributor Author

@neriousy It was a decision made by David months ago, all the built-in themes point to that url, I am also not sure if people can make custom themes outside the opencode repo. If they can, would be nice to have this hosted.

But its your pick, anyone works, just want to be sure of how its meant to be used, so I decided to go with what was commited months ago.

Yeah im seeing commits from 8 months ago, with this set, so I think they had a plan or smth idk, then again could be agents just following stuff.

@OpeOginni

Copy link
Copy Markdown
Contributor Author

Thought about it, If maybe in the future there is a feature for custom desktop themes, I do think it should be hosted then, just like themes for the TUI

@Enough1122

Copy link
Copy Markdown

AI code review — automated review for reference; please use your judgment.

No blocking issues found.

  • packages/console/app/package.json:10 (nit) — cp inside the build script only works on POSIX shells; on Windows (where this repo's scripts are also developed/run) bun run build for the console will fail since cmd.exe/PowerShell don't provide cp. A cross-platform form like bun -e "await Bun.write('./.output/public/desktop-theme.json', Bun.file('../../ui/src/theme/desktop-theme.schema.json'))" (or a tiny script alongside generate-sitemap.ts) would keep the build portable.

@Enough1122

Copy link
Copy Markdown

AI code review — automated review for reference; please use your judgment.

  • packages/console/app/package.json:10 — cp won't exist in plain cmd.exe on Windows dev machines; fine for CI/Linux but consider a portable alternative (bun -e "Bun.write(...)" or node fs copy) if local Windows builds matter.
  • Naming: source is desktop-theme.schema.json but it publishes as desktop-theme.json — intentional for URL aesthetics? If consumers fetch a JSON Schema, a .schema.json suffix may communicate intent better.
  • Otherwise clean, minimal fix.

@github-actions

Copy link
Copy Markdown
Contributor

Automated PR Cleanup

Thank you for contributing to opencode.

Due to the high volume of PRs from users and AI agents, we periodically close older PRs using automated criteria so maintainers can focus review time on the most active and community-supported contributions.

This PR was closed because it matched the following cleanup criteria:

  • The PR was created more than 1 month ago
  • The PR had fewer than 2 positive reactions
  • Positive reactions are counted as thumbs-up, heart, celebration, or rocket reactions on the PR

PRs created within the last month are not affected by this cleanup.

If you believe this PR was closed incorrectly, or if you are still actively working on it, please leave a comment explaining why it should be reopened. A maintainer can review and reopen it if appropriate.

Thanks again for taking the time to contribute.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Desktop Theme Schema path returns 404.

3 participants