Repository navigation
Conversation
|
Shouldn't this point at the file inside repo rather than hosted? Like people who have the repo cloned would be using the desktop schema stuff - hosting it on the website seems off for me |
|
@neriousy It was a decision made by David months ago, all the built-in themes point to that url, I am also not sure if people can make custom themes outside the opencode repo. If they can, would be nice to have this hosted. But its your pick, anyone works, just want to be sure of how its meant to be used, so I decided to go with what was commited months ago. Yeah im seeing commits from 8 months ago, with this set, so I think they had a plan or smth idk, then again could be agents just following stuff. |
|
Thought about it, If maybe in the future there is a feature for custom desktop themes, I do think it should be hosted then, just like themes for the TUI |
No blocking issues found.
|
|
|
Automated PR Cleanup Thank you for contributing to opencode. Due to the high volume of PRs from users and AI agents, we periodically close older PRs using automated criteria so maintainers can focus review time on the most active and community-supported contributions. This PR was closed because it matched the following cleanup criteria:
PRs created within the last month are not affected by this cleanup. If you believe this PR was closed incorrectly, or if you are still actively working on it, please leave a comment explaining why it should be reopened. A maintainer can review and reopen it if appropriate. Thanks again for taking the time to contribute. |
Issue for this PR
Type of change
What does this PR do?
/desktop-theme.jsonduring the console build.How did you verify your code works?
bun run buildfrompackages/console/app.desktop-theme.jsonmatches the source schema.Checklist