Repository navigation
test(app): update e2e specs for always-background subagents - #63538
Conversation
User decisions: - Fix the tests that fail because subagents now always run in the background
There was a problem hiding this comment.
This test-only change looks sound. On the base, the seven affected app e2e cases fail as described. With this pull request, all of them pass in a local Playwright run (76 of 78 in the two specs). The two failures are in static projection tests that this pull request doesn't touch: one also fails on the base here, and the other passed on the base, so it looks environment-dependent rather than caused by this change. typecheck:e2e has one fewer error than the base and no new ones in these specs.
Public API: unchanged. Only e2e specs are modified.
The new fixtures are simpler than before. Using shellCommands replaces the hand-sent shell.created event, and status("idle", …) replaces the as never transport cast. I have no concerns.
Fixes the app e2e specs that fail on
devsince subagents always run in the background (#63382, #63391). Seven cases fail on both Linux and Windowse2e (…, app-2), e.g. run 43205730927. Test-only change.timeline-geometry.spec.ts"scrolls the timeline behind the composer region…" (pointer, touch)1 subagentpill. Same geometry checks.timeline-stream.spec.ts"counts a backgrounded subagent…"(background)subtitle and sentbackground: truestatus: "running"while the child's idle → busy → idle drives the count.timeline-stream.spec.ts"separates blocking and already-backgrounded work…"1 subagent · 1 shellmenu, interrupt, shell output and kill.timeline-stream.spec.ts"holds a revealed call … under its stuck group header" (3 variants)session-timeline-row.tsx→virtualizer.tsxrevealPart). The standalone "jumps from a finished shell's notice to its call" case is folded into these, keeping its assertions.The describe block is renamed "background work". No product code changes.
🚩 Flag: none (test).
📊 Proof (production build, 5 workers, fully parallel, no retries)
--repeat-each=10: 70/70 pass.typecheck:tscpasses in app.typecheck:e2ehas 1 fewer error than base and no new ones. Prettier and oxlint are clean.