Fix issue 1878 - Regression test failure with delete global graphs - #1881
Merged
Conversation
Fixed issue 1878, an issue with delete_global_graphs during parallel regression tests. Added locking and some more defensive copies. No regression tests were impacted.
jrgemignani
requested review from
MuhammadTahaNaveed,
Zainab-Saad,
dehowef and
rafsun42
May 17, 2024 00:02
rafsun42
approved these changes
May 17, 2024
jrgemignani
added a commit
to jrgemignani/age
that referenced
this pull request
May 17, 2024
…pache#1881) Fixed issue 1878, an issue with delete_global_graphs during parallel regression tests. Added locking and some more defensive copies. No regression tests were impacted.
jrgemignani
added a commit
to jrgemignani/age
that referenced
this pull request
May 17, 2024
…pache#1881) Fixed issue 1878, an issue with delete_global_graphs during parallel regression tests. Added locking and some more defensive copies. No regression tests were impacted.
jrgemignani
added a commit
to jrgemignani/age
that referenced
this pull request
May 17, 2024
…pache#1881) Fixed issue 1878, an issue with delete_global_graphs during parallel regression tests. Added locking and some more defensive copies. No regression tests were impacted.
jrgemignani
added a commit
to jrgemignani/age
that referenced
this pull request
May 17, 2024
…pache#1881) Fixed issue 1878, an issue with delete_global_graphs during parallel regression tests. Added locking and some more defensive copies. No regression tests were impacted.
jrgemignani
added a commit
to jrgemignani/age
that referenced
this pull request
Aug 9, 2024
…pache#1881) Fixed issue 1878, an issue with delete_global_graphs during parallel regression tests. Added locking and some more defensive copies. No regression tests were impacted.
jrgemignani
added a commit
to jrgemignani/age
that referenced
this pull request
Aug 9, 2024
…pache#1881) Fixed issue 1878, an issue with delete_global_graphs during parallel regression tests. Added locking and some more defensive copies. No regression tests were impacted.
This was referenced Jun 9, 2026
Closed
jrgemignani
pushed a commit
that referenced
this pull request
Jun 9, 2026
…2433) The pthread_mutex in manage_GRAPH_global_contexts() causes permanent self-deadlock when ereport(ERROR) triggers siglongjmp while the mutex is held, skipping pthread_mutex_unlock(). Any subsequent VLE query on the same backend connection hangs forever in pthread_mutex_lock() with __owner == own PID. The mutex was introduced in PR #1881 (fix for issue #1878) but is unnecessary: it protects a process-local static variable in PostgreSQL's single-threaded backend model where no concurrent access exists. The actual fix for #1878 was the Assert-to-runtime-check conversion and strndup defensive copy, which remain untouched.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed issue 1878, an issue with delete_global_graphs during parallel regression tests.
Added locking and some more defensive copies.
No regression tests were impacted.