Skip to content

Support runners other than DirectRunner for :examples:java:execute#35262

Merged
Abacn merged 1 commit into
apache:masterfrom
Abacn:exectask
Jun 17, 2025
Merged

Support runners other than DirectRunner for :examples:java:execute#35262
Abacn merged 1 commit into
apache:masterfrom
Abacn:exectask

Conversation

@Abacn

@Abacn Abacn commented Jun 12, 2025

Copy link
Copy Markdown
Contributor

Please add a meaningful description for your change here


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@Abacn

Abacn commented Jun 12, 2025

Copy link
Copy Markdown
Contributor Author

Tested with

./gradlew :examples:java:execute -PmainClass=org.apache.beam.examples.WordCount -Pexec.args=" \
       --runner=DataflowRunner \
       --region=us-central1 \
       --tempLocation=gs://.../tmp/ \
       --project=... \
       --jobName=$USER-wordcount-job
       --output=gs://.../output/output.txt \
       --experiments=use_staged_dataflow_worker_jar

@github-actions

Copy link
Copy Markdown
Contributor

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

@Abacn

Abacn commented Jun 13, 2025

Copy link
Copy Markdown
Contributor Author

R: @shunping

Java PreCommit currently failing due to #35274 #35233

@github-actions

Copy link
Copy Markdown
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

@shunping

Copy link
Copy Markdown
Collaborator

@shunping

shunping commented Jun 13, 2025

Copy link
Copy Markdown
Collaborator

Trying to revert the first red master run (https://github.com/apache/beam/actions/runs/15566528898). Let's see if the check can pass with this.
#35276

@Abacn

Abacn commented Jun 13, 2025

Copy link
Copy Markdown
Contributor Author

It was due to #35233 and #35252, the latter one is fixed. Random PrismRunner tests still failing

@Abacn

Abacn commented Jun 13, 2025

Copy link
Copy Markdown
Contributor Author
* What went wrong:
Execution failed for task ':runners:prism:java:test'.
> There were failing tests. See the report at: file:///runner/_work/beam/beam/runners/prism/java/build/reports/tests/test/index.html

BUILD FAILED in 13m 16s

windowing (org.apache.beam.runners.prism.PrismRunnerTest) failed

runners/prism/java/build/test-results/test/TEST-org.apache.beam.runners.prism.PrismRunnerTest.xml [took 2s]

org.apache.beam.vendor.grpc.v1p69p0.io.grpc.StatusRuntimeException: UNAVAILABLE: Network closed for unknown reason
	at app//org.apache.beam.vendor.grpc.v1p69p0.io.grpc.stub.ClientCalls.toStatusRuntimeException(ClientCalls.java:268)
	at app//org.apache.beam.vendor.grpc.v1p69p0.io.grpc.stub.ClientCalls.getUnchecked(ClientCalls.java:249)
	at app//org.apache.beam.vendor.grpc.v1p69p0.io.grpc.stub.ClientCalls.blockingUnaryCall(ClientCalls.java:167)
	at app//org.apache.beam.model.jobmanagement.v1.JobServiceGrpc$JobServiceBlockingStub.run(JobServiceGrpc.java:717)

latest run there is a single prism runner test failing, not related to this change

PTAL @shunping

@shunping

Copy link
Copy Markdown
Collaborator

Given the previous failed Java PreCommit tests on prism have been fixed at #35336, I think it is safe to LGTM here.

@Abacn
Abacn merged commit c6605ef into apache:master Jun 17, 2025
23 of 26 checks passed
@Abacn
Abacn deleted the exectask branch June 17, 2025 20:08
@codecov

codecov Bot commented Jun 17, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.50%. Comparing base (de76cfa) to head (8b6756a).
Report is 59 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master   #35262   +/-   ##
=========================================
  Coverage     54.50%   54.50%           
  Complexity     1479     1479           
=========================================
  Files          1017     1017           
  Lines        160983   160983           
  Branches       1079     1079           
=========================================
  Hits          87737    87737           
  Misses        71140    71140           
  Partials       2106     2106           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants