This repository was archived by the owner on Mar 12, 2026. It is now read-only.
fix: Cherry-pick commits removed in PR:1000#1013
Closed
MichaelLeeHZ wants to merge 3 commits into
Closed
Conversation
The metadata for arrow schema is encoded into the parquet file. However, this part is lost when building our custom metadata. Keep the other metadata in the parquet metadata after extracting our custom metadata. Add unit test `test_arrow_meta_data` for it.
Part of apache#990. Some background jobs are still allowed to execute, and it will lead to data corrupted when a table is migrated between different nodes because of multiple writers for the same table. Introduce a flag called `invalid` in the table data to denote whether the serial executor is valid, and this flag is protected with the `TableOpSerialExecutor` in table data, and the `TableOpSerialExecutor` won't be acquired if the flag is set, that is to say, any table operation including updating manifest, altering table and so on, can't be executed after the flag is set because these operations require the `TableOpSerialExecutor`. Finally, the flag will be set when the table is closed.
## Rationale In current design, sst files may be picked multiple times. ## Detailed Changes - Mark files as in compacting when pick files candidates, and reset it to false when CompactionTask is dropped. ## Test Plan Manually
Member
|
@MachaelLee I guess we should do revert on #1000, cherry-pick in this PR seems not perfect, and I'm not sure whether any other problems will be introduced. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
In PR:#1000, some commits were removed.
Detailed Changes
Test Plan