Skip to content
This repository was archived by the owner on Mar 12, 2026. It is now read-only.

chore: remove the codes about the reverse reading#1116

Merged
ShiKaiWi merged 3 commits into
apache:mainfrom
ShiKaiWi:fix-remove-reverse-scan
Aug 1, 2023
Merged

chore: remove the codes about the reverse reading#1116
ShiKaiWi merged 3 commits into
apache:mainfrom
ShiKaiWi:fix-remove-reverse-scan

Conversation

@ShiKaiWi

@ShiKaiWi ShiKaiWi commented Jul 28, 2023

Copy link
Copy Markdown
Member

Rationale

Currently, the read in a reverse order of primary key is not supported yet. Remove the codes about that.

Detailed Changes

Remove the codes about the reverse read during plan stage and reading sst stage, while the ability to scan memtable in reverse order is kept for possible future use.

Test Plan

Existing tests.

@jiacai2050 jiacai2050 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ShiKaiWi ShiKaiWi merged commit ee10f2f into apache:main Aug 1, 2023
@ShiKaiWi ShiKaiWi deleted the fix-remove-reverse-scan branch August 1, 2023 05:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants