Skip to content
This repository was archived by the owner on Mar 12, 2026. It is now read-only.

refactor: add datafusion default optimizer rules#1147

Merged
jiacai2050 merged 2 commits into
apache:mainfrom
jiacai2050:issue-1087
Aug 11, 2023
Merged

refactor: add datafusion default optimizer rules#1147
jiacai2050 merged 2 commits into
apache:mainfrom
jiacai2050:issue-1087

Conversation

@jiacai2050

Copy link
Copy Markdown
Contributor

Rationale

Close #1087

Detailed Changes

  • Remove unnecessary custom optimizer rules, use datafusion default ones.

Test Plan

Integration tests.

@jiacai2050 jiacai2050 requested a review from Rachelint August 11, 2023 07:00
Comment thread query_engine/src/datafusion_impl/physical_planner.rs Outdated
Comment thread query_engine/src/datafusion_impl/physical_planner.rs Outdated

@Rachelint Rachelint left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jiacai2050 jiacai2050 merged commit 965327a into apache:main Aug 11, 2023
@jiacai2050 jiacai2050 deleted the issue-1087 branch August 11, 2023 10:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use more optimize rule in datafusion

2 participants