Skip to content
This repository was archived by the owner on Mar 12, 2026. It is now read-only.

feat: teach ceresdb to encode/decode datafusion physical plan#1177

Merged
Rachelint merged 8 commits into
apache:mainfrom
Rachelint:dist-sql-query-codec
Aug 29, 2023
Merged

feat: teach ceresdb to encode/decode datafusion physical plan#1177
Rachelint merged 8 commits into
apache:mainfrom
Rachelint:dist-sql-query-codec

Conversation

@Rachelint

@Rachelint Rachelint commented Aug 25, 2023

Copy link
Copy Markdown
Contributor

Rationale

Part of #1112
If we want to send plan to remote, we must encode it first.

Detailed Changes

  • Impl extension codec of dist_sql_query related physical plans.
  • Remove the useless PhysicalPlanCodec and its impl.
  • Refactor the pb converting about ReadRequest.

Test Plan

Test by new ut.

@Rachelint Rachelint marked this pull request as ready for review August 28, 2023 03:15
Comment thread df_engine_extensions/src/codec.rs

@jiacai2050 jiacai2050 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Rachelint Rachelint merged commit 0263791 into apache:main Aug 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants