Skip to content
This repository was archived by the owner on Mar 12, 2026. It is now read-only.

fix: ensure channel size non zero#1345

Merged
jiacai2050 merged 3 commits into
apache:devfrom
jiacai2050:fix-chan-buf
Dec 6, 2023
Merged

fix: ensure channel size non zero#1345
jiacai2050 merged 3 commits into
apache:devfrom
jiacai2050:fix-chan-buf

Conversation

@jiacai2050

Copy link
Copy Markdown
Contributor

Rationale

When channel capacity < read_parallelism, we will pass 0 to channel, which will cause panic

2023-12-05 20:31:32.974 ERRO [components/panic_ext/src/lib.rs:54] thread 'ceres-read' panicked 'mpsc bounded channel requires buffer > 0' at "analytic_engine/src/sst/parquet/async_reader.rs:736"

Detailed Changes

  • Ensure channel size non zero

Test Plan

No need.

@Rachelint Rachelint left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jiacai2050 jiacai2050 merged commit 22b724c into apache:dev Dec 6, 2023
@jiacai2050 jiacai2050 deleted the fix-chan-buf branch December 6, 2023 09:52
@jiacai2050 jiacai2050 restored the fix-chan-buf branch December 28, 2023 03:23
@jiacai2050 jiacai2050 deleted the fix-chan-buf branch November 22, 2024 06:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants