Skip to content
This repository was archived by the owner on Mar 12, 2026. It is now read-only.

fix: table name is normalized when find timestamp column#1446

Merged
ZuLiangWang merged 5 commits into
apache:mainfrom
jiacai2050:fix-priority
Jan 22, 2024
Merged

fix: table name is normalized when find timestamp column#1446
ZuLiangWang merged 5 commits into
apache:mainfrom
jiacai2050:fix-priority

Conversation

@jiacai2050

@jiacai2050 jiacai2050 commented Jan 19, 2024

Copy link
Copy Markdown
Contributor

Rationale

Detailed Changes

  • Use get_table_ref to get TableReference, which will not normalize table name
  • Return error when timestamp column is not found.

Test Plan

CI

Comment thread src/query_frontend/src/plan.rs
ZuLiangWang
ZuLiangWang previously approved these changes Jan 19, 2024

@ZuLiangWang ZuLiangWang left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ZuLiangWang ZuLiangWang left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ZuLiangWang ZuLiangWang merged commit 264826e into apache:main Jan 22, 2024
@jiacai2050 jiacai2050 deleted the fix-priority branch January 22, 2024 02:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants