Skip to content
This repository was archived by the owner on Mar 12, 2026. It is now read-only.

fix: changes required for migrate dev to main#1455

Merged
ShiKaiWi merged 5 commits into
apache:mainfrom
jiacai2050:feat-migrate
Jan 23, 2024
Merged

fix: changes required for migrate dev to main#1455
ShiKaiWi merged 5 commits into
apache:mainfrom
jiacai2050:feat-migrate

Conversation

@jiacai2050

@jiacai2050 jiacai2050 commented Jan 22, 2024

Copy link
Copy Markdown
Contributor

Rationale

When rename ceresdb to horaedb, there are some breaking changes.

In order to allow old version to upgrade to main branch, some changes are required.

Detailed Changes

  • Make default catalog configurable via env vars,

Test Plan

Manually.

Before upgrade, first setup required envs

export HORAEDB_DEFAULT_CATALOG=ceresdb

Etcd's root should be configured both in horaedb and horaemeta

For horaedb

[cluster_deployment.etcd_client]
server_addrs = ['127.0.0.1:2379']
root_path = "/rootPath"

For horaemeta

storage-root-path = "/rootPath"

Then

  1. Upgrade horaemeta, then horaedb will throw following errors, which is expected
2024-01-23 14:37:57.726 ERRO [src/cluster/src/cluster_impl.rs:136] Send heartbeat to meta failed, err:Failed to send heartbeat, cluster:defaultCluster, err:status: Unimplemented, message: "unknown service meta_service.MetaRpcService", details: [], metadata: MetadataMap { headers: {"content-type": "application/grpc"} }

  1. Upgrade horaedb, after all server upgraded, the cluster should be ready for read/write, and old data could be queried like before.

@jiacai2050 jiacai2050 marked this pull request as ready for review January 23, 2024 06:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants