Skip to content
This repository was archived by the owner on Mar 12, 2026. It is now read-only.

fix: check ASF header for all source files#1497

Merged
jiacai2050 merged 4 commits into
apache:mainfrom
jiacai2050:fix-headers
Mar 12, 2024
Merged

fix: check ASF header for all source files#1497
jiacai2050 merged 4 commits into
apache:mainfrom
jiacai2050:fix-headers

Conversation

@jiacai2050

@jiacai2050 jiacai2050 commented Mar 11, 2024

Copy link
Copy Markdown
Contributor

Rationale

All source file should have ASF headers.

Detailed Changes

Test Plan

CI

@CLAassistant

CLAassistant commented Mar 11, 2024

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@jiacai2050 jiacai2050 changed the title fix: check all files fix: check ASF header for all source files Mar 11, 2024
tanruixiang
tanruixiang approved these changes Mar 12, 2024
View reviewed changes

@tanruixiang tanruixiang left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jiacai2050 jiacai2050 merged commit 5aeb8cc into apache:main Mar 12, 2024
@jiacai2050 jiacai2050 deleted the fix-headers branch March 12, 2024 02:39
chunshao90 pushed a commit that referenced this pull request Mar 12, 2024
@jiacai2050 @chunshao90
fix: check ASF header for all source files (#1497)
2a9f12a 
## Rationale
All source file should have ASF headers.

## Detailed Changes


## Test Plan
CI
@chunshao90 chunshao90 mentioned this pull request Mar 19, 2024
Open
zealchen pushed a commit to zealchen/incubator-horaedb that referenced this pull request Apr 9, 2024
@jiacai2050 @zealchen
fix: check ASF header for all source files (apache#1497)
fe6121f 
## Rationale
All source file should have ASF headers.

## Detailed Changes


## Test Plan
CI
zealchen pushed a commit to zealchen/incubator-horaedb that referenced this pull request Apr 9, 2024
@jiacai2050 @zealchen
fix: check ASF header for all source files (apache#1497)
a8c1825 
## Rationale
All source file should have ASF headers.

## Detailed Changes


## Test Plan
CI
zealchen pushed a commit to zealchen/incubator-horaedb that referenced this pull request Apr 9, 2024
@jiacai2050 @zealchen
fix: check ASF header for all source files (apache#1497)
e4ca207 
## Rationale
All source file should have ASF headers.

## Detailed Changes


## Test Plan
CI
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@tanruixiang tanruixiang tanruixiang approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jiacai2050 @CLAassistant @tanruixiang