This repository was archived by the owner on Mar 12, 2026. It is now read-only.
refactor: remove cluster version#669
Merged
Merged
Conversation
84509d1 to
8af6247
Compare
2974503 to
c9294f6
Compare
Codecov Report
@@ Coverage Diff @@
## main #669 +/- ##
==========================================
- Coverage 67.55% 67.47% -0.09%
==========================================
Files 281 282 +1
Lines 44343 44309 -34
==========================================
- Hits 29956 29896 -60
- Misses 14387 14413 +26
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Rachelint
reviewed
Mar 8, 2023
chunshao90
pushed a commit
to chunshao90/ceresdb
that referenced
this pull request
May 15, 2023
* refactor: remove version of region in WAL * refactor: set up server * refactor: setup procedure * refactor: fix unit test * chore: rename context to build context * fix: avoid wal dropped when reopen * chore: avoid useless config updating in ut * fix: wrong config for test write buffer * fix: implement close region for table-kv based wal * chore: fix missing wals for no meta mode
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #663
Rationale for this change
Remove the useless cluster version in the WAL location, which is introduced by #442 to solve the problems mentioned in #441.
What changes are included in this PR?
close_regionin theWalManagertrait;close_regioninstead of using different cluster version;Wals in the top level structs;Are there any user-facing changes?
None.
How does this change test
Existing tests.