This repository was archived by the owner on Mar 12, 2026. It is now read-only.
feat: support split write request to batches for small wal logs#754
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #754 +/- ##
==========================================
+ Coverage 68.24% 68.30% +0.06%
==========================================
Files 296 296
Lines 46011 46306 +295
==========================================
+ Hits 31399 31630 +231
- Misses 14612 14676 +64
... and 4 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
jiacai2050
reviewed
Mar 23, 2023
Rachelint
reviewed
Mar 23, 2023
Rachelint
reviewed
Mar 23, 2023
cef70ce to
dabfa4e
Compare
chunshao90
pushed a commit
to chunshao90/ceresdb
that referenced
this pull request
May 15, 2023
…he#754) * feat: support split write request to batches for small wal logs * test: add unit test for the split write requests * fix: rename the config option name * chore: add some comments * chore: explain that `max_bytes_per_write_batch` will break atomicity * refactor: do maybe_split_write_request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #
Rationale for this change
Currently, one large write request may lead to one large WAL log, which is not friendly for some wal implementations.
What changes are included in this PR?
Are there any user-facing changes?
None.
How does this change test
New unit tests and existing integraion tests.