Skip to content
This repository was archived by the owner on Mar 12, 2026. It is now read-only.

chore: add write batch metrics#827

Merged
jiacai2050 merged 3 commits into
apache:mainfrom
jiacai2050:chore-write-metrics
Apr 12, 2023
Merged

chore: add write batch metrics#827
jiacai2050 merged 3 commits into
apache:mainfrom
jiacai2050:chore-write-metrics

Conversation

@jiacai2050

@jiacai2050 jiacai2050 commented Apr 11, 2023

Copy link
Copy Markdown
Contributor

Which issue does this PR close?

Closes #819

Rationale for this change

Write batch size is important for write throughput.

What changes are included in this PR?

Add histgram metrics for write batch

Are there any user-facing changes?

No

How does this change test

No need

Comment thread analytic_engine/src/table/metrics.rs Outdated

@ShiKaiWi ShiKaiWi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jiacai2050 jiacai2050 added this pull request to the merge queue Apr 12, 2023
Merged via the queue into apache:main with commit 23592bd Apr 12, 2023
chunshao90 pushed a commit to chunshao90/ceresdb that referenced this pull request May 15, 2023
* chore: add write batch metrics

* fix CI

* fix CR
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add write batch size metrics

2 participants