Skip to content
This repository was archived by the owner on Mar 12, 2026. It is now read-only.

fix: new multiple write requests when tag names are different#888

Merged
chunshao90 merged 1 commit into
apache:mainfrom
jiacai2050:fix-prom-write
May 11, 2023
Merged

fix: new multiple write requests when tag names are different#888
chunshao90 merged 1 commit into
apache:mainfrom
jiacai2050:fix-prom-write

Conversation

@jiacai2050

Copy link
Copy Markdown
Contributor

Which issue does this PR close?

Closes #

Rationale for this change

For one metric, when tag name is different, it cannot be in same write request

What changes are included in this PR?

Use (metric, tag_names) as group key when new write requests

Are there any user-facing changes?

No

How does this change test

CI and manually

@chunshao90 chunshao90 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chunshao90 chunshao90 merged commit 9e85ce0 into apache:main May 11, 2023
chunshao90 pushed a commit to chunshao90/ceresdb that referenced this pull request May 15, 2023
@jiacai2050 jiacai2050 deleted the fix-prom-write branch November 22, 2024 06:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants