This repository was archived by the owner on Mar 12, 2026. It is now read-only.
feat: Implement multipart upload of object store#913
Merged
Conversation
This was referenced May 22, 2023
chunshao90
reviewed
May 23, 2023
chunshao90
left a comment
Contributor
There was a problem hiding this comment.
Is it better to implement ObjectStorage trait?
ShiKaiWi
reviewed
May 23, 2023
Co-authored-by: WEI Xikai <ShiKaiWi@users.noreply.github.com>
Co-authored-by: WEI Xikai <ShiKaiWi@users.noreply.github.com>
Co-authored-by: WEI Xikai <ShiKaiWi@users.noreply.github.com>
ShiKaiWi
reviewed
May 24, 2023
ShiKaiWi
reviewed
May 24, 2023
ShiKaiWi
reviewed
May 24, 2023
ShiKaiWi
reviewed
May 24, 2023
Co-authored-by: WEI Xikai <ShiKaiWi@users.noreply.github.com>
Co-authored-by: WEI Xikai <ShiKaiWi@users.noreply.github.com>
Co-authored-by: WEI Xikai <ShiKaiWi@users.noreply.github.com>
Co-authored-by: WEI Xikai <ShiKaiWi@users.noreply.github.com>
…eresdb into feat-object-store-multipart
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
Closes #912
Detailed Changes
Define a trait
CloudMultiPartUploadImplthat can be implemented by cloud-based object stores, which refers toobject_storeinarrow_rs.Test Plan
Test in #887