Skip to content
This repository was archived by the owner on Mar 12, 2026. It is now read-only.

refactor: disk cache use partition lock#974

Merged
jiacai2050 merged 15 commits into
apache:mainfrom
tanruixiang:disk_cache_use_partition_lock
Jun 7, 2023
Merged

refactor: disk cache use partition lock#974
jiacai2050 merged 15 commits into
apache:mainfrom
tanruixiang:disk_cache_use_partition_lock

Conversation

@tanruixiang

@tanruixiang tanruixiang commented Jun 7, 2023

Copy link
Copy Markdown
Member

Rationale

Close #914

Detailed Changes

Use partition lock in disk cache

Test Plan

add ut.

@jiacai2050 jiacai2050 self-requested a review June 7, 2023 02:37
@tanruixiang tanruixiang marked this pull request as ready for review June 7, 2023 03:07
Comment thread common_util/src/partitioned_lock.rs
Comment thread components/object_store/src/disk_cache.rs Outdated
Comment thread components/object_store/src/disk_cache.rs
Comment thread common_util/src/partitioned_lock.rs
Comment thread analytic_engine/src/setup.rs Outdated
Comment thread common_util/src/partitioned_lock.rs Outdated
Comment thread components/object_store/src/disk_cache.rs Outdated
Comment thread components/object_store/src/disk_cache.rs Outdated
Comment thread components/object_store/src/disk_cache.rs Outdated
@tanruixiang tanruixiang force-pushed the disk_cache_use_partition_lock branch from 3efb2f9 to 39bc0eb Compare June 7, 2023 07:45

@jiacai2050 jiacai2050 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jiacai2050 jiacai2050 changed the title Disk cache use partition lock refactor: disk cache use partition lock Jun 7, 2023
@jiacai2050 jiacai2050 merged commit 25899eb into apache:main Jun 7, 2023
@tanruixiang tanruixiang deleted the disk_cache_use_partition_lock branch June 13, 2023 11:48
dust1 pushed a commit to dust1/ceresdb that referenced this pull request Aug 9, 2023
## Rationale
Close apache#914

## Detailed Changes
Use `partition lock` in `disk cache`

## Test Plan
add ut.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use partitioned lock to optimize disk cache

2 participants