Skip to content
This repository was archived by the owner on Mar 12, 2026. It is now read-only.

refactor: add partition num as param in partition lock's init_fn#981

Merged
jiacai2050 merged 9 commits into
apache:mainfrom
tanruixiang:modify_interface
Jun 9, 2023
Merged

refactor: add partition num as param in partition lock's init_fn#981
jiacai2050 merged 9 commits into
apache:mainfrom
tanruixiang:modify_interface

Conversation

@tanruixiang

@tanruixiang tanruixiang commented Jun 9, 2023

Copy link
Copy Markdown
Member

Rationale

Detailed Changes

  • Add a param(partition_num) in partition lock's init_fn.

Test Plan

UT

Comment thread components/object_store/src/disk_cache.rs Outdated
Comment thread components/object_store/src/disk_cache.rs Outdated
@jiacai2050 jiacai2050 changed the title refactor: modify the all partitionlock's interface refactor: add a param in partition lock's init_fn Jun 9, 2023

@jiacai2050 jiacai2050 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jiacai2050 jiacai2050 changed the title refactor: add a param in partition lock's init_fn refactor: add partition num as param in partition lock's init_fn Jun 9, 2023
@jiacai2050 jiacai2050 merged commit c4572b9 into apache:main Jun 9, 2023
@tanruixiang tanruixiang deleted the modify_interface branch June 13, 2023 11:48
dust1 pushed a commit to dust1/ceresdb that referenced this pull request Aug 9, 2023
…che#981)

## Rationale

## Detailed Changes
- Add a param(partition_num) in partition lock's init_fn.

## Test Plan
UT
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants