Skip to content
This repository was archived by the owner on Mar 12, 2026. It is now read-only.

refactor: avoid grpc forwarding twice#991

Merged
ShiKaiWi merged 2 commits into
apache:mainfrom
baojinri:refactor-avoid-grpc-continuous-forwarding
Jun 16, 2023
Merged

refactor: avoid grpc forwarding twice#991
ShiKaiWi merged 2 commits into
apache:mainfrom
baojinri:refactor-avoid-grpc-continuous-forwarding

Conversation

@baojinri

Copy link
Copy Markdown
Contributor

Rationale

Close #984

Detailed Changes

Add a parameter to the headers of grpc to mark that it has been forwarded.

Test Plan

Existing tests

@baojinri baojinri marked this pull request as ready for review June 13, 2023 09:20
Comment thread proxy/src/grpc/sql_query.rs Outdated
@ShiKaiWi ShiKaiWi changed the title refactor: avoid grpc continuous forwarding refactor: avoid grpc forwarding twice Jun 15, 2023
@baojinri baojinri force-pushed the refactor-avoid-grpc-continuous-forwarding branch from 3cd9210 to 85d0a10 Compare June 15, 2023 06:48
Comment thread proxy/src/forward.rs Outdated
Comment thread proxy/src/forward.rs Outdated
Comment thread proxy/src/lib.rs Outdated

@ShiKaiWi ShiKaiWi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ShiKaiWi ShiKaiWi merged commit 032c448 into apache:main Jun 16, 2023
@baojinri baojinri deleted the refactor-avoid-grpc-continuous-forwarding branch June 19, 2023 02:05
dust1 pushed a commit to dust1/ceresdb that referenced this pull request Aug 9, 2023
## Rationale
Close apache#984 

## Detailed Changes
Add a parameter to the headers of grpc to mark that it has been
forwarded.

## Test Plan
Existing tests
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Prevent continuous forwarding between multiple nodes

2 participants