Skip to content
This repository was archived by the owner on Mar 12, 2026. It is now read-only.

feat: use dictionary type to store column#993

Merged
jiacai2050 merged 19 commits into
apache:mainfrom
tanruixiang:support_dictionary
Jul 5, 2023
Merged

feat: use dictionary type to store column#993
jiacai2050 merged 19 commits into
apache:mainfrom
tanruixiang:support_dictionary

Conversation

@tanruixiang

@tanruixiang tanruixiang commented Jun 15, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

Rationale

close #1039

Detailed Changes

Add dictionary type

Test Plan

ut.

@tanruixiang tanruixiang marked this pull request as ready for review June 28, 2023 07:07
@tanruixiang tanruixiang requested a review from jiacai2050 June 28, 2023 07:07
jiacai2050
jiacai2050 reviewed Jul 3, 2023
View reviewed changes
Comment thread analytic_engine/src/sst/parquet/encoding.rs Outdated
Comment thread analytic_engine/src/sst/parquet/hybrid.rs Outdated
Comment thread analytic_engine/src/sst/parquet/writer.rs Outdated
Comment thread common_types/src/column.rs Outdated
Comment thread common_types/src/column.rs Outdated
Comment thread common_types/src/column.rs Outdated
@tanruixiang tanruixiang requested a review from jiacai2050 July 4, 2023 03:38
jiacai2050
jiacai2050 reviewed Jul 4, 2023
View reviewed changes
Comment thread common_types/src/column_schema.rs
Comment thread common_types/src/column_schema.rs Outdated
Comment thread query_frontend/src/parser.rs Outdated
Comment thread table_engine/src/memory.rs Outdated
Comment thread query_frontend/src/planner.rs Outdated
Comment thread common_types/src/column.rs Outdated
Comment thread common_types/src/column.rs Outdated
Comment thread common_types/src/column.rs
Comment thread common_types/src/column.rs
Comment thread common_types/src/column.rs
jiacai2050
jiacai2050 reviewed Jul 4, 2023
View reviewed changes
Comment thread proxy/src/http/prom.rs Outdated
jiacai2050
jiacai2050 reviewed Jul 4, 2023
View reviewed changes
Comment thread proxy/src/influxdb/types.rs Outdated
jiacai2050
jiacai2050 reviewed Jul 5, 2023
View reviewed changes
Comment thread common_types/src/tests.rs
jiacai2050
jiacai2050 reviewed Jul 5, 2023
View reviewed changes
Comment thread query_frontend/src/parser.rs Outdated
jiacai2050
jiacai2050 approved these changes Jul 5, 2023
View reviewed changes

@jiacai2050 jiacai2050 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jiacai2050 jiacai2050 merged commit 4a7c6e4 into apache:main Jul 5, 2023
@tanruixiang tanruixiang deleted the support_dictionary branch July 12, 2023 01:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@jiacai2050 jiacai2050 jiacai2050 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support write and read dictionary encoding column

2 participants

@tanruixiang @jiacai2050