Skip to content
This repository was archived by the owner on Mar 11, 2026. It is now read-only.

support disable vendored protoc#81

Merged
Rachelint merged 1 commit into
mainfrom
feat-disable-vendor
Jun 25, 2023
Merged

support disable vendored protoc#81
Rachelint merged 1 commit into
mainfrom
feat-disable-vendor

Conversation

@jiacai2050

@jiacai2050 jiacai2050 commented Jun 21, 2023

Copy link
Copy Markdown
Contributor

Add CERESDBPROTO_ENABLE_VENDORED to control whether use vendored protoc, which defaults to true.

The reason I want to add this is because stepancheg/rust-protoc-bin-vendored#1.

@jiacai2050 jiacai2050 requested review from Rachelint and ShiKaiWi June 25, 2023 06:54

@Rachelint Rachelint left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Rachelint Rachelint merged commit 4fdc664 into main Jun 25, 2023
@jiacai2050 jiacai2050 deleted the feat-disable-vendor branch June 25, 2023 07:00
jiacai2050 added a commit to apache/horaedb that referenced this pull request Jun 25, 2023
## Rationale
See apache/incubator-horaedb-proto#81

After this, developers can set `export
CERESDBPROTO_ENABLE_VENDORED=false` to use protoc on their host.

## Detailed Changes


## Test Plan
No need.
dust1 pushed a commit to dust1/ceresdb that referenced this pull request Aug 9, 2023
## Rationale
See apache/incubator-horaedb-proto#81

After this, developers can set `export
CERESDBPROTO_ENABLE_VENDORED=false` to use protoc on their host.

## Detailed Changes


## Test Plan
No need.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants