Skip to content

Use JUnit5 in failsafe ITs#3251

Merged
slawekjaranowski merged 1 commit into
apache:masterfrom
slawekjaranowski:failsafe-junit5-it
Feb 4, 2026
Merged

Use JUnit5 in failsafe ITs#3251
slawekjaranowski merged 1 commit into
apache:masterfrom
slawekjaranowski:failsafe-junit5-it

Conversation

@slawekjaranowski
Copy link
Copy Markdown
Member

also improvements to use artifacts from current build reactor

now ITs download artifacts from snapshot repository, which is available by parent pom

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean install to make sure basic checks pass. A more thorough check will
    be performed on your pull request automatically.
  • You have run the integration tests successfully (mvn -Prun-its clean install).

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

also improvements to use artifacts from current build reactor

now ITs download artifacts from snapshot repository, which is available by parent pom
@slawekjaranowski
Copy link
Copy Markdown
Member Author

@olamy we should update parent pom ... but in newer parent we removed snapshot repositories which is used by ITs ...

After merge I will rebase it with your PR:

Copy link
Copy Markdown
Member

@olamy olamy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. don't worry I can rebase in the branch.

@slawekjaranowski
Copy link
Copy Markdown
Member Author

LGTM. don't worry I can rebase in the branch.

it can be some conflicts, so as you wish, I can try at evening

@slawekjaranowski slawekjaranowski merged commit fcf1f3c into apache:master Feb 4, 2026
14 checks passed
@slawekjaranowski slawekjaranowski deleted the failsafe-junit5-it branch February 4, 2026 09:46
@github-actions github-actions Bot added this to the 3.5.5 milestone Feb 4, 2026
@olamy
Copy link
Copy Markdown
Member

olamy commented Feb 4, 2026

LGTM. don't worry I can rebase in the branch.

it can be some conflicts, so as you wish, I can try at evening

All good I just did it.
thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants