Skip to content

[python] Add client versions to REST User-Agent.#8544

Open
zhoulii wants to merge 2 commits into
apache:masterfrom
zhoulii:feature/client-versions
Open

[python] Add client versions to REST User-Agent.#8544
zhoulii wants to merge 2 commits into
apache:masterfrom
zhoulii:feature/client-versions

Conversation

@zhoulii

@zhoulii zhoulii commented Jul 10, 2026

Copy link
Copy Markdown
Member

Purpose

close #8543

Tests

@JingsongLi JingsongLi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Directly changing the public configuration key 'header. HTTP_SUSER_AGENT' to 'header. User Agent' is not compatible with the old key. Reproduced locally: The old configuration will be silently ignored, and the actual sending will default to 'PyPaimon/...'; Depreciated/fallback compatibility should be retained.

@zhoulii
zhoulii force-pushed the feature/client-versions branch from 0bc32d7 to 4e88084 Compare July 13, 2026 04:17
@zhoulii

zhoulii commented Jul 13, 2026

Copy link
Copy Markdown
Member Author

Directly changing the public configuration key 'header. HTTP_SUSER_AGENT' to 'header. User Agent' is not compatible with the old key. Reproduced locally: The old configuration will be silently ignored, and the actual sending will default to 'PyPaimon/...'; Depreciated/fallback compatibility should be retained.

Thanks for pointing this out. I added Java-aligned fallback-key support on the Python side: header.User-Agent remains the canonical key, while the legacy header.HTTP_USER_AGENT is retained as a fallback. The legacy value is now correctly sent as the User-Agent header instead of falling back to
PyPaimon/....

@JingsongLi

Copy link
Copy Markdown
Contributor

cc @sundapeng to take a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature] Add sdk version information to REST User-Agent

2 participants