[format] Support Map<X, Blob> type for Blob File Format#8635
Open
steFaiz wants to merge 4 commits into
Open
Conversation
steFaiz
marked this pull request as draft
July 15, 2026 03:28
steFaiz
marked this pull request as ready for review
July 15, 2026 04:05
Contributor
|
cc @leaves12138 to take a look. |
JingsongLi
reviewed
Jul 16, 2026
JingsongLi
left a comment
Contributor
There was a problem hiding this comment.
Also support this in PrimaryKeyBlobExternalizer?
Contributor
Author
|
@JingsongLi Of course! But this PR only focus on file format layer modification. Wiring to Table & Engine layer will be brought in subsequent PRs. I'm afraid that modifying all layers in one PR is too big to review. |
Contributor
@steFaiz It is OK in a single PR. It’s important to have a complete implementation; if we run into difficulties during the review, we’ll split the PR then. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Supports writing Map<X, Blob> in BlobFormatTable, following #8181
This PR only focus on Blob File Format of Java and Python module, keeping this PR reasonably small.
This PR DO NOT involes:
Key Changes:
Xonly supports some simple non-nested type: String and Int family.Tests
See unit tests