[flink] Support end input in coordinator commit#8671
[flink] Support end input in coordinator commit#8671fishfishfishfishaa wants to merge 6 commits into
Conversation
|
- Defer coordinator Context initialization - Pass actual streamingCheckpointEnabled from FlinkSink - Sync for END_INPUT event completion in batch mode - Remove unnecessary empty snapshot check in streaming IT
|
Regarding the ITCase failure in batch mode: due to the asynchronous architecture of the coordinator, the batch job finishes first, and close() interrupts the final commit. I've adjusted it to use synchronous blocking for batch EndInput events. Since this is not waiting for the last EndInput event — it only waits for in-memory operations — the blocking time is minimal. Moreover, EndInput itself is in the "finalization" phase. Compared to other approaches, I believe this design is simpler and more consistent with the original logic. (Other alternatives include: 1. Modifying close() to wait for all pending commits; 2. Explicitly waiting only for the last one; 3. Adding an ack mechanism.) Additionally, the coordinator Context initialization issue has also been fixed. |
"the batch coordinator path bypasses BatchWriteGeneratorTagOperator, and tag.automatic-creation=batch silently fails to create a tag" still not fix yet |
|
…l operator commit logic
|
For batch automatic tag, I have added validation to prevent silent failures. I will complete the support for this in a follow-up, and it will be tracked later in #8220. @ifndef-SleePy PTAL and let me know if you have any suggestions. Thanks! |
Purpose
This PR implements the end-of-input handling that was intentionally left out of the core coordinator-commit PR for [PIP-30 #8220 ].
It extends
sink.coordinator-commit.enabledto correctly finish and commit bounded inputs. In particular, coordinator commit now supports batch jobs without checkpointing, and correctly handles bounded streaming jobs after all writers reachendInput.This PR is built on top of the core coordinator-commit implementation. It does not change the default committer-operator path.
What changes
Commit after all writers finish
Each coordinated writer emits a final committable entry with
Long.MAX_VALUEas a dedicated end-of-input checkpoint ID when Flink invokesendInput.The JobManager-side
CommittingWriteOperatorCoordinatortracks this entry separately from ordinary checkpoint committables:filterAndCommit(..., false, true).For streaming jobs with checkpointing enabled, the final commit remains aligned with checkpoint completion. This preserves the normal checkpoint-driven commit model while allowing some subtasks to finish before others.
For batch jobs, where checkpointing is normally disabled, the coordinator commits immediately after receiving end-input entries from all writer subtasks.
Support batch coordinator commit
Coordinator commit previously required streaming mode with checkpointing enabled. This is now relaxed as follows:
The existing coordinator-commit restrictions remain unchanged: it only supports write-only unaware-bucket append tables, and still rejects configurations such as primary-key tables, precommit compaction, auto-tag-for-savepoint, and concurrent checkpoints.
The option documentation is updated accordingly.
Preserve end-input state across recovery
End input is not an ordinary checkpoint: it is newer than every checkpoint and may need to survive restore even if Flink does not invoke
endInputagain after recovery.To make this safe:
endInputis invoked again after restore, the writer merges newly produced final committables with the persisted entry and sends one authoritative final entry.WriterCommittablestreats end input separately from the maximum ordinary checkpoint, so it does not incorrectly constrain ordinary checkpoint alignment.This also handles region failover while the coordinator is still waiting for the remaining writers to finish.
End-input watermark handling
The writer now uses
end-input.watermark, when configured, for the final end-input committable.For ordinary checkpoints after a subtask has finished, that subtask contributes
Long.MAX_VALUEto the watermark minimum. This makes a finished writer neutral and prevents it from incorrectly holding back the watermark of active writers.The final commit uses the configured end-input watermark as expected.
How it works
Tests
This PR adds coverage for:
end-input.watermark.WriterCommittablessemantics:No production behavior changes when
sink.coordinator-commit.enabledis disabled.