Repository navigation
Fix exception messages that always printed null - #1373
Merged
Merged
Conversation
Each message was built inside a null check and printed the null value itself (SpotBugs NP_LOAD_OF_KNOWN_NULL_VALUE), or in HwmfMisc the value that failed to resolve instead of the raw value read. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SpotBugs flags these messages: each one is built inside a null check and prints the value that was just found to be
null(NP_LOAD_OF_KNOWN_NULL_VALUE). This PR only changes message text; no exception types or code paths change.AgileEncryptionHeaderInvalid hash size: nullMissing hash size in the key dataFormulaParser.parseStructuredReference(one column)Cannot parse column: null with formula …Cannot parse column: missing column name in formula …EllipseInvalid cell 'null' in Ellipse rowCell without a name in Ellipse rowPackageRelationshipCollection.getRelationshipByID… provided ID is empty: null, having relationships: …… no ID provided, having relationships: …WmfDibCreatePatternBrushCould not read color-usage nullCould not read color-usage <value read>The HWMF message printed the enum lookup that had failed; it now prints the raw value read from the file, which is what's useful when investigating.
No tests assert on these messages.
🤖 Generated with Claude Code