Refactor: container export a tar archive - #1303
Merged
Merged
Conversation
JaewonHur
requested changes
Mar 9, 2026
JaewonHur
approved these changes
Mar 10, 2026
Signed-off-by: ChengHao Yang <17496418+tico88612@users.noreply.github.com>
Signed-off-by: ChengHao Yang <17496418+tico88612@users.noreply.github.com>
Signed-off-by: ChengHao Yang <17496418+tico88612@users.noreply.github.com>
Signed-off-by: ChengHao Yang <17496418+tico88612@users.noreply.github.com>
Contributor
Author
|
Uh, forgot the final |
JaewonHur
approved these changes
Mar 11, 2026
Contributor
Author
|
@jglogan sorry for ping, could you ban vxnkjyffmq-code ? This account send many spam messages here. |
stephenlclarke
added a commit
to stephenlclarke/container
that referenced
this pull request
Jul 10, 2026
Export the immutable image snapshot recorded in runtime configuration when a created container has not materialized its writable rootfs yet. Existing stopped containers continue to export their writable bundle disk. Upstream-Ref: apple#1265 Upstream-Ref: apple#1303 Release-Highlight: Exports containers immediately after container create, enabling Compose Bridge transformer source generation without starting the image.
stephenlclarke
added a commit
to stephenlclarke/container
that referenced
this pull request
Jul 10, 2026
Use persisted bundle filesystem metadata whenever a container has been materialized, and consult runtime configuration only for a genuinely never-started container. This keeps stopped-container exports faithful while enabling image-snapshot export immediately after create. Refs: apple#1265 Refs: apple#1303 Release-Highlight: Exporting a never-started container now works without changing stopped-container filesystem semantics.
stephenlclarke
added a commit
to stephenlclarke/container
that referenced
this pull request
Jul 10, 2026
Treat only a missing bundle rootfs description as evidence that a container has never started. Preserve decoding and I/O failures so export cannot silently substitute the immutable image snapshot for a materialized container filesystem. Refs: apple#1265 Refs: apple#1303
stephenlclarke
added a commit
to stephenlclarke/container
that referenced
this pull request
Jul 10, 2026
Exercise export against a never-started container with deliberately malformed bundle rootfs metadata and verify that no archive is produced. This protects the materialized-filesystem guard from regressing into image-snapshot fallback. Refs: apple#1265 Refs: apple#1303
stephenlclarke
added a commit
to stephenlclarke/container-compose
that referenced
this pull request
Jul 10, 2026
Load compose-go's public Bridge model and the Swift runtime projection in one pass, enrich it with runnable image metadata and file-backed resources, and execute Kubernetes, Helm, custom, and repeated transformations safely. Create transformer sources by exporting never-started containers and securely selecting the templates subtree. Match Docker's table, JSON, quiet, list, and ls discovery behavior, including digest aliases and platform-aware size selection. Upstream-Ref: docker/compose#13482 Upstream-Ref: docker/compose#13483 Upstream-Ref: docker/compose-bridge-transformer#22 Upstream-Ref: apple/container#1265 Upstream-Ref: apple/container#1303 Release-Highlight: Compose Bridge now carries published ports plus text and binary configs and secrets into Kubernetes, Helm, and custom transformations. Release-Highlight: bridge transformations create now extracts templates from stopped transformer images without running them (apple/container#1265, apple/container#1303). Release-Highlight: bridge transformations list and ls now match Docker table, JSON, and quiet output, including digest-only images. Release-Highlight: Versioned official Bridge transformers now run reliably on Apple silicon through the compatibility path fixed by docker/compose-bridge-transformer#22.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Change
Motivation and Context
Fixed #1265
Testing