Write file data into archive only for regular files - #1403
Merged
Conversation
Signed-off-by: Aditya Ramani <a_ramani@apple.com>
adityaramani
force-pushed
the
build-context-symlink
branch
from
April 7, 2026 22:21
72d177a to
995169a
Compare
wlan0
suggested changes
Apr 8, 2026
wlan0
left a comment
Contributor
There was a problem hiding this comment.
Good fix for the archive write path
The digest logic gets broken however.
compress() hashes ArchiveEntryInfo, which doesn't include fileType or symlinkTarget. In case of symlinks, no bytes are hashed either.
This means, symlink target paths can change without changing the entire digest's hash.
A clean fix would be to either add fileType/symlinkTarget fields to ArchiveEntryInfo, or hash entry.symlinkTarget in _compressFile() for symlinks.
Contributor
Author
|
@wlan0 Thanks for catching that. Updated the |
wlan0
approved these changes
Apr 8, 2026
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Change
Motivation and Context
Closes #1375
Testing