Use NetworkResource for network management in API server. - #1421
Merged
Conversation
jglogan
marked this pull request as draft
April 15, 2026 15:51
jglogan
marked this pull request as ready for review
April 17, 2026 18:45
14 tasks
ajemory
reviewed
Apr 18, 2026
jglogan
force-pushed
the
network-resource
branch
2 times, most recently
from
April 19, 2026 18:52
ce02137 to
3906eb5
Compare
- Evolves API to use a `NetworkResource` that conforms to `ManagedResource`. - BREAKING CHANGE - compile time impact due to changes to Swift client API signatures. No change to persistent data or API server XPC protocols.
jglogan
force-pushed
the
network-resource
branch
from
April 23, 2026 21:18
7de4489 to
5652235
Compare
ajemory
approved these changes
Apr 28, 2026
noah-thor
pushed a commit
to noah-thor/container
that referenced
this pull request
May 6, 2026
- Part of apple#1404. - Evolves API to use NetworkResource that conforms to ManagedResource. - BREAKING CHANGE - compile time impact due to changes to Swift client API signatures. No change to persistent data or API server XPC protocols.
2 tasks
katiewasnothere
added a commit
that referenced
this pull request
May 28, 2026
## Type of Change - [x] New feature ## Motivation and Context Related to #1404. This PR adds the initial work to have volume resources conform to ManagedResource, in alignment with other resources such as networks (see [here](#1421)). Further work is necessary to move the use of `VolumeResource` down to the APIServer (in the VolumesService) and in the volume client. Volumes do not currently have any plugin or runtime state, so that information is not included in the `VolumeResource`, but could be added later if needed. ## Testing - [x] Tested locally Signed-off-by: Kathryn Baldauf <k_baldauf@apple.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Change
Motivation and Context
Evolve API to 1.0 shape.
Testing