Simplify the serial suite trait - #1497
Merged
Merged
Conversation
Signed-off-by: Kathryn Baldauf <k_baldauf@apple.com>
noah-thor
reviewed
May 1, 2026
| } | ||
| } | ||
|
|
||
| @Suite struct SuiteGateTests { |
Contributor
There was a problem hiding this comment.
does the behavior get tested already in the AsyncLock code?
Contributor
Author
There was a problem hiding this comment.
Looks like no. I can add some tests in containerization for AsyncLock. AsyncLock is being used in critical paths in containerization though (VZVirtualMachineInstance and ImageStore.create, for example).
Contributor
There was a problem hiding this comment.
...and in pretty much all of the container-apiserver services so that they don't have to deal with actor reentrancy.
jglogan
approved these changes
May 1, 2026
dcantah
pushed a commit
to apple/containerization
that referenced
this pull request
May 1, 2026
These tests were requested as part of a test change in apple/container#1497. These tests mimic a lot of the tests in https://github.com/apple/containerization/blob/main/Tests/ContainerizationExtrasTests/AsyncMutexTests.swift where possible/appropriate. Signed-off-by: Kathryn Baldauf <k_baldauf@apple.com>
noah-thor
pushed a commit
to noah-thor/container
that referenced
this pull request
May 6, 2026
## Motivation and Context The `SuiteGate` actor introduced for the serial test trait in apple#1489 could be simplified using containerization's [AsyncLock](https://github.com/apple/containerization/blob/f2c42402e744df992fecb84eb3a82935c6fa01d3/Sources/ContainerizationExtras/AsyncLock.swift#L23). ## Testing - [ ] Tested locally Note: working on A/B performance testing to validate this approach does not significantly impact test run performance. Signed-off-by: Kathryn Baldauf <k_baldauf@apple.com>
simone-panico
pushed a commit
to simone-panico/containerization
that referenced
this pull request
May 19, 2026
These tests were requested as part of a test change in apple/container#1497. These tests mimic a lot of the tests in https://github.com/apple/containerization/blob/main/Tests/ContainerizationExtrasTests/AsyncMutexTests.swift where possible/appropriate. Signed-off-by: Kathryn Baldauf <k_baldauf@apple.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
The
SuiteGateactor introduced for the serial test trait in #1489 could be simplified using containerization's AsyncLock.Testing
Note: working on A/B performance testing to validate this approach does not significantly impact test run performance.