Remove XPC compatibility code, simplify network model. - #1616
Merged
Conversation
- Refactor network model types: replace `NetworkState` enum and phase-based NetworkStatus with a flat `NetworkStatus` struct. - Simplify API server ↔ plugin protocol: plugin `status()` returns runtime status only, API server owns configuration. - `NetworksService` `list()`/`create()` now return `NetworkResource` directly. - Remove lifecycle phase checks and state machine guards throughout CLI and API server.
14 tasks
- `variant` is plugin-specific, it's not a required property. This PR replaces `NetworkPluginInfo` with a `plugin` name property on `NetworkConfiguration` and an `options` list similar to that for volumes. - Moved `variant` to the option list.
Code Coverage
|
katiewasnothere
approved these changes
May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NetworkStateenum and phase-based NetworkStatus with a flatNetworkStatusstruct.status()returns runtime status only, API server owns configuration.NetworksServicelist()/create()now returnNetworkResourcedirectly.variantis plugin-specific, it's not a required property. This PR replacesNetworkPluginInfowith apluginname property onNetworkConfigurationand anoptionslist similar to that for volumes.variantto the option list.Type of Change
Motivation and Context
Lots of tech debt around redundant types, clearing out XPC compatibility code for 0.x releases.
Testing