Skip to content

Always update default network with system configuration values - #1686

Merged
katiewasnothere merged 1 commit into
apple:mainfrom
katiewasnothere:update_default_net_store_from_config
Jun 11, 2026
Merged

Always update default network with system configuration values#1686
katiewasnothere merged 1 commit into
apple:mainfrom
katiewasnothere:update_default_net_store_from_config

Conversation

@katiewasnothere

Copy link
Copy Markdown
Contributor

Type of Change

  • Bug fix

Motivation and Context

Closes #1677.

Future work:

  • we should add a dedicated CLI test suite for updating toml values

Testing

  • Tested locally

Signed-off-by: Kathryn Baldauf <k_baldauf@apple.com>
@katiewasnothere
katiewasnothere force-pushed the update_default_net_store_from_config branch from 7147b07 to df29f28 Compare June 10, 2026 21:00
@github-actions

Copy link
Copy Markdown

Code Coverage

Tier Line Coverage
Unit 33.23%
Integration 21.11%
Combined 53.52%

@katiewasnothere
katiewasnothere merged commit c8b4fd7 into apple:main Jun 11, 2026
3 checks passed
@katiewasnothere
katiewasnothere deleted the update_default_net_store_from_config branch June 11, 2026 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: TOML network subnet setting not applied to VM

2 participants