Show disk usage in image list - #1720
Conversation
|
@amarkdotdev thanks for the PR! If this addition reports the same value as that of the If the value is a reasonable approximation of disk usage, I prefer what you have – |
|
Thanks, that makes sense. This value is not exactly the same shape as the verbose |
1152087 to
3104d5a
Compare
3104d5a to
e97d1a8
Compare
|
Thanks for the heads-up @saehejkang. I took a look at #991 — I think the two changes are complementary rather than conflicting:
The only file they both touch is On the naming: per @jglogan's preference above I've kept |
|
Hi @jglogan — just checking in on this when you have a moment. Happy to rename the column to match verbose output if you prefer; my earlier note was that the default table shows one row per image reference while verbose lists per-platform variants, so the semantics differ slightly. Open to whatever naming keeps the UX clearest. Also saw @saehejkang's pointer to #991 — still looks complementary from my side (#991 fixes size calculation; this adds a default-column size display). Let me know if you'd like any changes before review. Thanks! |
e97d1a8 to
8e2111b
Compare
|
@jglogan Gentle ping — you commented on the Quick recap: default table shows one row per image reference with aggregated non-attestation variant sizes; verbose still lists per-platform Also noting CI hasn't run on this fork PR — let me know if you need anything from my side to get workflows going. Thanks! |
|
@jglogan Kind ping :) |
8e2111b to
6845188
Compare
|
hey @jglogan. rebased onto main. mind approving the CI workflow so checks can run, then reviewing when you get a chance? kept the DISK USAGE naming as discussed. |
6845188 to
dd0edbf
Compare
Signed-off-by: amarkdotdev <amarkdotdev@users.noreply.github.com>
dd0edbf to
6518915
Compare
|
@jglogan rebased again. Mind approving the CI workflow and reviewing when you get a chance? |
Type of Change
Motivation and Context
container image listdid not include disk usage in the default table output. This adds aDISK USAGEcolumn using the same per-variant size data already used by verbose image listing, while excluding attestation manifests reported with theunknown/unknownplatform.Fixes #1712
Testing
Validation run locally:
swift test --filter ContainerCommandsTests