Skip to content

Show disk usage in image list - #1720

Open
amarkdotdev wants to merge 1 commit into
apple:mainfrom
amarkdotdev:codex/image-list-disk-usage
Open

Show disk usage in image list#1720
amarkdotdev wants to merge 1 commit into
apple:mainfrom
amarkdotdev:codex/image-list-disk-usage

Conversation

@amarkdotdev

Copy link
Copy Markdown

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation update

Motivation and Context

container image list did not include disk usage in the default table output. This adds a DISK USAGE column using the same per-variant size data already used by verbose image listing, while excluding attestation manifests reported with the unknown/unknown platform.

Fixes #1712

Testing

  • Tested locally
  • Added/updated tests
  • Added/updated docs

Validation run locally:

  • swift test --filter ContainerCommandsTests

@jglogan

jglogan commented Jun 14, 2026

Copy link
Copy Markdown
Contributor

@amarkdotdev thanks for the PR! If this addition reports the same value as that of the FULL SIZE column reported with --verbose, perhaps we should label the columns identically for both non-verbose and verbose usage?

If the value is a reasonable approximation of disk usage, I prefer what you have – DISK USAGE – to FULL SIZE.

@amarkdotdev

Copy link
Copy Markdown
Author

Thanks, that makes sense. This value is not exactly the same shape as the verbose FULL SIZE column: verbose output emits one row per platform variant, while the default table has one row per image reference and aggregates the non-attestation variant sizes for that image. Given that, I think DISK USAGE is the clearer label here.

@amarkdotdev
amarkdotdev force-pushed the codex/image-list-disk-usage branch from 1152087 to 3104d5a Compare June 15, 2026 15:21
@jglogan
jglogan self-requested a review June 15, 2026 16:54
@saehejkang

Copy link
Copy Markdown
Contributor

@jglogan This PR is related (somewhat) to the changes here and is been ready for a final ✅ . Just wanted to bring it to your inbox, in case there is overlap here.

@amarkdotdev
amarkdotdev force-pushed the codex/image-list-disk-usage branch from 3104d5a to e97d1a8 Compare June 16, 2026 05:42
@amarkdotdev

Copy link
Copy Markdown
Author

Thanks for the heads-up @saehejkang. I took a look at #991 — I think the two changes are complementary rather than conflicting:

The only file they both touch is docs/command-reference.md, and the edits are in different sections, so whichever lands second is a trivial rebase. If #991 merges first and the team would prefer the default column to reuse its improved size semantics, I'm happy to follow up and align this column with it.

On the naming: per @jglogan's preference above I've kept DISK USAGE (the default-table value aggregates per-image variant sizes, which is a slightly different shape than the verbose per-variant FULL SIZE). Happy to adjust if you'd like them unified. PTAL whenever you have a moment.

@amarkdotdev

Copy link
Copy Markdown
Author

Hi @jglogan — just checking in on this when you have a moment. Happy to rename the column to match verbose output if you prefer; my earlier note was that the default table shows one row per image reference while verbose lists per-platform variants, so the semantics differ slightly. Open to whatever naming keeps the UX clearest.

Also saw @saehejkang's pointer to #991 — still looks complementary from my side (#991 fixes size calculation; this adds a default-column size display). Let me know if you'd like any changes before review. Thanks!

@amarkdotdev
amarkdotdev force-pushed the codex/image-list-disk-usage branch from e97d1a8 to 8e2111b Compare June 28, 2026 06:46
@amarkdotdev

Copy link
Copy Markdown
Author

@jglogan Gentle ping — you commented on the DISK USAGE vs FULL SIZE naming back in June and I think we're aligned, but this hasn't had a formal review yet.

Quick recap: default table shows one row per image reference with aggregated non-attestation variant sizes; verbose still lists per-platform FULL SIZE. Happy to align with #991's improved size semantics if that's landed and you'd prefer consistency.

Also noting CI hasn't run on this fork PR — let me know if you need anything from my side to get workflows going. Thanks!

@amarkdotdev

Copy link
Copy Markdown
Author

@jglogan Kind ping :)

@amarkdotdev
amarkdotdev force-pushed the codex/image-list-disk-usage branch from 8e2111b to 6845188 Compare July 21, 2026 19:16
@amarkdotdev

Copy link
Copy Markdown
Author

hey @jglogan. rebased onto main. mind approving the CI workflow so checks can run, then reviewing when you get a chance? kept the DISK USAGE naming as discussed.

@amarkdotdev
amarkdotdev force-pushed the codex/image-list-disk-usage branch from 6845188 to dd0edbf Compare July 27, 2026 20:29
Signed-off-by: amarkdotdev <amarkdotdev@users.noreply.github.com>
@amarkdotdev
amarkdotdev force-pushed the codex/image-list-disk-usage branch from dd0edbf to 6518915 Compare July 28, 2026 03:25
@amarkdotdev

Copy link
Copy Markdown
Author

@jglogan rebased again. Mind approving the CI workflow and reviewing when you get a chance?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Request]: container i ls display DISK USAGE

3 participants