Fix CLITest when run in xcode - #1775
Merged
jglogan merged 1 commit intoJun 20, 2026
Merged
Conversation
3 tasks
Contributor
Author
|
Related issue: #1776 |
jglogan
approved these changes
Jun 20, 2026
| "ContainerLog", | ||
| "ContainerPersistence", | ||
| "ContainerResource", | ||
| "MachineAPIClient", |
Contributor
There was a problem hiding this comment.
Good catch:
% grep -r MachineAPIClient Tests
Tests/CLITests/Subcommands/Machine/TestCLIMachine.swift:import MachineAPIClient
Contributor
Author
|
I pushed a new empty commit that is signed, sorry, I messed that up before. |
Contributor
|
@mareksapota Yep, it looks like you got signing set up - reset your branch, re-commit your Package.swift change and force push the branch and you should be fine. |
Summary: Running a single test from `TestCLIMachine` in xcode errors out because: Warning: ``` 'CLITests' is missing a dependency on 'MachineAPIClient' because dependency scan of Swift module 'CLITests' discovered a dependency on 'MachineAPIClient' ``` Error: ``` /Volumes/src/apple/container/Package.swift:1:1 Undefined symbol: MachineAPIClient.MachineConfiguration.containerUUIDLength.unsafeMutableAddressor : Swift.Int ``` This change fixes the errors. Test plan: I clicked the run button left of `func testCreate` in `TestCLIMachine`, xcode built the project and run the test successfully.
mareksapota
force-pushed
the
mareksapota-fix-xcode-single-test-run-package-deps
branch
from
June 20, 2026 17:59
933e192 to
9c8ab87
Compare
Contributor
Author
|
Force pushed, unverified commit is gone/replaced. |
Code Coverage
|
Contributor
|
@mareksapota Merged, thanks for finding the issue and fixing it! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Change
Motivation and Context
Running a single test from
TestCLIMachinein xcode errors out because:Warning:
Error:
This change fixes the errors.
Testing
Test plan:
I clicked the run button left of
func testCreateinTestCLIMachine, xcode built the project and run the test successfully.