Skip to content

Remove duplicate release workflow that double-builds and races on every tag - #1781

Merged
jglogan merged 2 commits into
apple:mainfrom
radheradhe01:fix/dedupe-release-workflows
Jun 26, 2026
Merged

Remove duplicate release workflow that double-builds and races on every tag#1781
jglogan merged 2 commits into
apple:mainfrom
radheradhe01:fix/dedupe-release-workflows

Conversation

@radheradhe01

Copy link
Copy Markdown
Contributor

Closes #1755.

.github/workflows/release.yml and .github/workflows/release-build.yml are byte-for-byte identical (same blob SHA) and both trigger on the same release-tag push ([0-9]+\.[0-9]+\.[0-9]+), with no concurrency: group. So every release tag starts two identical workflow runs:

  • the full build + package pipeline (common.yml, timeout-minutes: 75) runs twice; and
  • both runs call softprops/action-gh-release for the same tag and assets, which can race.

This is observable in the Actions history: both workflows ran at the identical timestamp for 1.0.0, 0.12.3, 0.12.1, 0.12.0 and 0.11.0 — and for 0.12.2 one of the two runs was cancelled while the other succeeded.

This change removes release-build.yml, which was added later as a copy of release.yml (#550), restoring a single release workflow.

If you'd prefer to keep release-build.yml and drop release.yml instead, or keep both behind a concurrency: { group: release-${{ github.ref }} } guard, I'm happy to switch — they're identical, so any of those resolves the double-run.

release-build.yml is byte-identical to release.yml and triggers on the same release-tag push with no concurrency guard, so every tag starts two identical build+publish runs. Remove the later-added copy.
@jglogan

jglogan commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

@radheradhe01 let's keep release-build.yaml. That was an age ago, but it looks like we went with the convention -build.yaml and I forgot to delete the older release.yaml.

Thank you for cleaning this up!

@github-actions

Copy link
Copy Markdown

Code Coverage

Tier Line Coverage
Unit 33.34%
Integration 23.02%
Combined 55.52%

@jglogan jglogan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@radheradhe01 thanks! I'll rename the file for consistency with the others in a follow-on PR, since I'm working on the integration tests and workflows atm.

@jglogan
jglogan merged commit af71f87 into apple:main Jun 26, 2026
7 of 9 checks passed
saehejkang pushed a commit to saehejkang/container that referenced this pull request Jul 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Duplicate tag-triggered release workflows (release.yml + release-build.yml) double-build every tag and can race to publish the same release

2 participants