Log the graceful-stop error instead of silently discarding it in gracefulStopContainer - #1782
Merged
Merged
Conversation
The catch around the graceful-stop attempt in gracefulStopContainer was empty, swallowing any error before the fall-through to lc.stop(). Add a log line matching the file convention.
Code Coverage
|
jglogan
approved these changes
Jun 23, 2026
jglogan
left a comment
Contributor
There was a problem hiding this comment.
@radheradhe01 This looks good to me - thank you for adding that bit of observability.
stephenlclarke
pushed a commit
to stephenlclarke/container
that referenced
this pull request
Jun 24, 2026
…efulStopContainer (apple#1782) - Closes apple#1756. - `RuntimeService.gracefulStopContainer(_:signal:timeout:)` wraps the graceful-stop attempt in `do { … } catch {}`. The empty catch silently discards any thrown error before falling through to the unconditional `lc.stop()`. It is the only catch in this file that does not log; every other one uses `self.log.error(…, metadata: ["error": "\(error)"])`. - This adds a single log line matching that convention, so a failed graceful stop (and the resulting fall-through to a forced VM shutdown) is more diagnosable. The intentional fall-through to `lc.stop()` is unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1756.
RuntimeService.gracefulStopContainer(_:signal:timeout:)wraps the graceful-stop attempt indo { … } catch {}— an empty catch that silently discards any thrown error before falling through to the unconditionallc.stop(). It is the only catch in this file that does not log; every other one usesself.log.error(…, metadata: ["error": "\(error)"]).This adds a single log line matching that convention, so a failed graceful stop (and the resulting fall-through to a forced VM shutdown) is diagnosable. The intentional fall-through to
lc.stop()is unchanged.