Remove network variant computation from API server. - #1814
Merged
Conversation
- Closes apple#1812. - The network plugin is the source of truth for the variant, if any, that applies to the network. Resolving a missing variant configuration option in the API server can create a situation where the variant the runtime uses for interface selection is incorrect.
katiewasnothere
approved these changes
Jun 25, 2026
Code Coverage
|
saehejkang
pushed a commit
to saehejkang/container
that referenced
this pull request
Jul 16, 2026
- Closes apple#1812. - The network plugin is the source of truth for the variant, if any, that applies to the network. Resolving a missing variant configuration option in the API server can create a situation where the variant the runtime uses for interface selection is incorrect. - Adds serial suites trait to tests to see whether it helps current CI issues. ## Type of Change - [x] Bug fix - [ ] New feature - [ ] Breaking change - [ ] Documentation update ## Motivation and Context Fixes a flaw in our interface strategy logic. ## Testing - [x] Tested locally - [ ] Added/updated tests - [ ] Added/updated docs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Change
Motivation and Context
Fixes a flaw in our interface strategy logic.
Testing