CLI: stop and delete should error on not found containers - #878
Merged
Conversation
dcantah
force-pushed
the
change-stop-and-kill-behavior
branch
from
November 14, 2025 01:26
cd90009 to
ace9702
Compare
dcantah
marked this pull request as ready for review
November 14, 2025 04:43
jglogan
previously requested changes
Nov 14, 2025
This was referenced Dec 18, 2025
dcantah
force-pushed
the
change-stop-and-kill-behavior
branch
from
February 16, 2026 12:25
ace9702 to
3a6aefe
Compare
Same as we'd done with kill. ➜ container git:(stop-kill-throw-error) ✗ ./bin/container stop foo bar baz Warning! Running debug build. Performance may be degraded. Error: internalError: "failed to stop container" (cause: "notFound: "container with ID baz not found"") internalError: "failed to stop container" (cause: "notFound: "container with ID bar not found"") internalError: "failed to stop container" (cause: "notFound: "container with ID foo not found"") ➜ container git:(stop-kill-throw-error) ✗ ./bin/container kill foo bar baz Warning! Running debug build. Performance may be degraded. Error: internalError: "failed to kill container" (cause: "notFound: "container with ID foo not found"") internalError: "failed to kill container" (cause: "notFound: "container with ID bar not found"") internalError: "failed to kill container" (cause: "notFound: "container with ID baz not found"") ➜ container git:(stop-kill-throw-error) ✗ ./bin/container delete foo bar baz Warning! Running debug build. Performance may be degraded. Error: internalError: "failed to delete container" (cause: "notFound: "container with ID foo not found"") internalError: "failed to delete container" (cause: "notFound: "container with ID baz not found"") internalError: "failed to delete container" (cause: "notFound: "container with ID bar not found"")
dcantah
force-pushed
the
change-stop-and-kill-behavior
branch
from
March 25, 2026 10:58
3a6aefe to
ca16820
Compare
jglogan
reviewed
Mar 25, 2026
jglogan
approved these changes
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same as we'd done with kill.