Skip to content

Changing hasIncompleteVersionstamp to use iteration rather than stream processing [release-7.1]#7559

Merged
jzhou77 merged 1 commit into
apple:release-7.1from
jzhou77:release-7.1
Jul 9, 2022
Merged

Changing hasIncompleteVersionstamp to use iteration rather than stream processing [release-7.1]#7559
jzhou77 merged 1 commit into
apple:release-7.1from
jzhou77:release-7.1

Conversation

@jzhou77
Copy link
Copy Markdown
Contributor

@jzhou77 jzhou77 commented Jul 9, 2022

Cherrypick #7552

Code-Reviewer Section

The general guidelines can be found here.

Please check each of the following things and check all boxes before accepting a PR.

  • The PR has a description, explaining both the problem and the solution.
  • The description mentions which forms of testing were done and the testing seems reasonable.
  • Every function/class/actor that was touched is reasonably well documented.

For Release-Branches

If this PR is made against a release-branch, please also check the following:

  • This change/bugfix is a cherry-pick from the next younger branch (younger release-branch or main if this is the youngest branch)
  • There is a good reason why this PR needs to go into a release branch and this reason is documented (either in the description above or in a linked GitHub issue)

@jzhou77 jzhou77 requested review from flowguru and jleach4 July 9, 2022 04:22
@fdb-windows-ci
Copy link
Copy Markdown
Collaborator

Doxense CI Report for Windows 10

@foundationdb-ci
Copy link
Copy Markdown
Contributor

Result of foundationdb-pr-macos on macOS BigSur 11.5.2

  • Commit ID: f40b947
  • Duration 0:34:32
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Logs (available for 30 days)

@foundationdb-ci
Copy link
Copy Markdown
Contributor

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

  • Commit ID: f40b947
  • Duration 0:40:05
  • Result: ❌ FAILED
  • Error: Error while executing command: tar -czf "${CODEBUILD_SRC_DIR}/packaging/docker/website/${FDB_VERSION}/fdb_${FDB_VERSION}.tar.gz" --directory "${CODEBUILD_SRC_DIR}/packaging/docker/website/${FDB_VERSION}" .. Reason: exit status 1
  • Build Logs (available for 30 days)

@foundationdb-ci
Copy link
Copy Markdown
Contributor

Result of foundationdb-pr on Linux CentOS 7

  • Commit ID: f40b947
  • Duration 0:59:24
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Logs (available for 30 days)

@jzhou77 jzhou77 merged commit 4c7890a into apple:release-7.1 Jul 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants