Skip to content

Once we start repairing a dead datacenter, don't allow it to be canceled (snowflake/release-71.3)#9769

Merged
sfc-gh-akejriwal merged 1 commit into
apple:snowflake/release-71.3from
sfc-gh-abeamon:fix-interrupted-dead-datacenter-repair-71.3
Mar 22, 2023
Merged

Once we start repairing a dead datacenter, don't allow it to be canceled (snowflake/release-71.3)#9769
sfc-gh-akejriwal merged 1 commit into
apple:snowflake/release-71.3from
sfc-gh-abeamon:fix-interrupted-dead-datacenter-repair-71.3

Conversation

@sfc-gh-abeamon
Copy link
Copy Markdown
Collaborator

Cherry-pick #9768

If we stop repairing a dead datacenter part way through (e.g. because quite database completed during the repair), then we might leave the cluster in an unintended state.

Code-Reviewer Section

The general pull request guidelines can be found here.

Please check each of the following things and check all boxes before accepting a PR.

  • The PR has a description, explaining both the problem and the solution.
  • The description mentions which forms of testing were done and the testing seems reasonable.
  • Every function/class/actor that was touched is reasonably well documented.

For Release-Branches

If this PR is made against a release-branch, please also check the following:

  • This change/bugfix is a cherry-pick from the next younger branch (younger release-branch or main if this is the youngest branch)
  • There is a good reason why this PR needs to go into a release branch and this reason is documented (either in the description above or in a linked GitHub issue)

@sfc-gh-abeamon sfc-gh-abeamon marked this pull request as ready for review March 21, 2023 22:09
@fdb-windows-ci
Copy link
Copy Markdown
Collaborator

Doxense CI Report for Windows 10

@foundationdb-ci
Copy link
Copy Markdown
Contributor

Result of foundationdb-pr on Linux CentOS 7

  • Commit ID: 965c479
  • Duration 0:57:40
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link
Copy Markdown
Contributor

Result of foundationdb-pr-clang on Linux CentOS 7

  • Commit ID: 965c479
  • Duration 0:57:57
  • Result: ❌ FAILED
  • Error: Error while executing command: if python3 -m joshua.joshua list --stopped | grep ${ENSEMBLE_ID} | grep -q 'pass=10[0-9][0-9][0-9]'; then echo PASS; else echo FAIL && exit 1; fi. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link
Copy Markdown
Contributor

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

  • Commit ID: 965c479
  • Duration 1:18:40
  • Result: ❌ FAILED
  • Error: Error while executing command: if $fail_test; then exit 1; fi. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)
  • Cluster Test Logs zip file of the test logs (available for 30 days)

@foundationdb-ci
Copy link
Copy Markdown
Contributor

Result of foundationdb-pr on Linux CentOS 7

  • Commit ID: 965c479
  • Duration 0:49:24
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link
Copy Markdown
Contributor

Result of foundationdb-pr-clang on Linux CentOS 7

  • Commit ID: 965c479
  • Duration 0:50:42
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link
Copy Markdown
Contributor

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

  • Commit ID: 965c479
  • Duration 1:22:05
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)
  • Cluster Test Logs zip file of the test logs (available for 30 days)

@sfc-gh-akejriwal sfc-gh-akejriwal merged commit bb58ffc into apple:snowflake/release-71.3 Mar 22, 2023
@sfc-gh-abeamon sfc-gh-abeamon deleted the fix-interrupted-dead-datacenter-repair-71.3 branch March 28, 2023 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants