Make removable location the default for bootloader installation#4030
Conversation
|
Addresses #4026 |
c7de7fb to
0c0b8b0
Compare
Also update the option's description to make it clear that it being enabled is the sane default.
0c0b8b0 to
6a0dfaa
Compare
|
Bump 👍🙏 |
|
@svartkanin IIRC we made this an option in the partitioning/grub menu, didn't we? to make it optional instead a forced default for everyone? |
|
Yes the problem is hardware support and text was miss-leading to press "No" |
|
I'm perfectly fine with updating the help text and descriptions. |
|
This reverts the behaviour to what it was before we added the dialog, in the sense that it defaults to removable just like it was before, when the dialog was not there to begin with. |
|
I can only find one old issue on the topic so maybe it's just my brain being biased that we used to have issues with the old |
|
https://www.reddit.com/r/arch/s/BGuxPuKNx8 (yesterday) I've seen quite a few in (since this has been the case the whole month) I also reproduced on quite recent msi board |
|
Ah I'm not debating that users are experiencing issues when So I'm worried that by adding back the old way of defaulting to tl;dr: I'm just nervous this brings back old bugs ^^ |
|
Ah makes sense. Perhaps just the help text being better is enough (its also documented on the grub page of wiki). And can default to False |
|
I would appreciate that, as it would make users less confused - but make me sleep better at night 😅 |
|
It seems both may cause issues for some users if not set correctly for their hardware. IMHO we should choose the default that represents the larger group of users and for whoever runs into the problem andd a FAQ entry in the README covering it. |
Torxed
left a comment
There was a problem hiding this comment.
After these changes, let's get it in and we'll push a new minor release before the new year :)
| if item.value: | ||
| return tr('Will install to /EFI/BOOT/ (removable location)') | ||
| return tr('Will install to standard location with NVRAM entry') | ||
| return tr('Will install to /EFI/BOOT/ (removable location, safe default)') |
There was a problem hiding this comment.
And we can keep the hints that help users choose removable=True!
|
I personally think that keeping it defaulting to true (as this PR already does) is probably for the best, unless there is an actual pop-up screen like Debian does that explains what the choice entails. Because whether one likes it or not, people are going to skip over a bunch of stuff and then land in support forums like the past month has shown. Generally speaking, there shouldn't really be an issue with going back to the default that archinstall already used, and using the removable location shouldn't really cause issues, or if it does, it should be in a smaller proportion than the reverse. |
|
If you think so, I'm happy to merge and see what happens ^^ |
Also update the option's description to make it clear that it being enabled is the sane default.