Rework has_default_btrfs_vols#4147
Merged
Merged
Conversation
svartkanin
approved these changes
Jan 20, 2026
svartkanin
reviewed
Jan 20, 2026
| @@ -201,13 +201,13 @@ def parse_arg( | |||
| return config | |||
|
|
|||
| def has_default_btrfs_vols(self) -> bool: | |||
Collaborator
There was a problem hiding this comment.
The function name was intended to indicate that we're looking for the default disk config as well so it doesn't make much sense anymore now no?
Contributor
Author
There was a problem hiding this comment.
Maybe not but it is still checking for something that relates to the default disk config (a root Btrfs subvolume with the name Path('@')), right? What do you suggest?
Collaborator
There was a problem hiding this comment.
Yeah not sure what a better name might be, I suppose if someone uses the default layout in the manual partitioning it would also be valid. Let's just leave it for now
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4146