Refactor/shared review scaffolding#101
Merged
Merged
Conversation
Replace hand-written Display/Error impls with thiserror derives for SemanticSearchError, CaptureEmbeddingError, AnalyzerError, PromptSourceError, and EmbedderError. Messages are unchanged. TransferError and BulkImportError keep manual impls: their Conflict variant has a `source: String` field that thiserror would mistake for an error source. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Convert the daily-review and signal modules (repository, service, prompt, generator, search, backfill) to thiserror derives. Introduce a small from_error_string! macro that replaces the hand-written From impls collapsing upstream errors into a string-carrying variant. Messages are unchanged. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
… types with thiserror Same mechanical conversion as the review module: thiserror derives replace hand-written Display/Error impls, and from_error_string! replaces the From impls that collapse sqlx errors into Storage/Database variants. Messages are unchanged. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…h thiserror Convert the delivery workers, validation errors, and ToolError to thiserror derives, completing the migration. The only hand-written error impls left are TransferError and BulkImportError, whose Conflict variant has a `source: String` field that thiserror would treat as an error source. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
TelegramDailyReviewSender and TelegramWeeklyReviewSender were identical except for names and the log line. Replace both with a single TelegramReviewSender in workers::telegram that implements each worker's sender trait, and merge the two identical SendOutcome enums into one shared ReviewSendOutcome. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
The four prompt modules (daily review, weekly review, signal extraction, entry extraction) duplicated the same config struct, env-override resolution, file loading, version derivation, error enum, and tests. Move the loading into prompts::file with a single PromptFile type and PromptFileError; each module keeps its own config type, env var, default path, and kind label for error messages. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.