Refactor: remove duplicate row mappers and inline single-use helpers#18
Merged
Merged
Conversation
asiniscalchi
commented
Apr 29, 2026
Owner
- Extract map_entry() in repository.rs, eliminating three identical JournalEntry row mapping closures across fetch_recent, fetch_today, and fetch_by_ids
- Extract map_search_result() in embedding/repository.rs, eliminating an identical EmbeddingSearchResult row mapping closure in search and search_for_user
- Inline log_daily_review_service_error(), which wrapped a single error! call used in exactly one place
- Add search_unavailable_response() to search.rs and use it in service.rs, replacing an inline string literal to follow the same pattern as all other response messages
- Extract map_entry() in repository.rs, eliminating three identical JournalEntry row mapping closures across fetch_recent, fetch_today, and fetch_by_ids - Extract map_search_result() in embedding/repository.rs, eliminating an identical EmbeddingSearchResult row mapping closure in search and search_for_user - Inline log_daily_review_service_error(), which wrapped a single error! call used in exactly one place - Add search_unavailable_response() to search.rs and use it in service.rs, replacing an inline string literal to follow the same pattern as all other response messages Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.