Fix/journal service embedder wiring#52
Merged
Merged
Conversation
Previously the journal service builder chained three RigOpenAiEmbedder::from_env calls inside an `if let ... && let Ok(_) && let Ok(_) && let Ok(_)`, so any one construction failure silently disabled the entire search subsystem with no log message. Construct the embedder once, log a warning on failure, and propagate the error via `?` to match spawn_embedding_worker / spawn_daily_review_embedding_worker. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
…sitory The journal service builder constructed three SemanticSearchService / SemanticDailyReviewSearchService / ImmediateCaptureEmbeddingService instances, each owning its own RigOpenAiEmbedder (and therefore its own OpenAI client). Add a blanket `impl<E: Embedder + ?Sized> Embedder for Arc<E>` so the embedder can be wrapped in an Arc once and shared across the three builders without changing their generic signatures, then use Arc::clone on the call site. Also build SqliteEmbeddingRepository once and Clone it for the search index, capture index, and pending-embedding counter rather than constructing three separate instances from pool.clone(). Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
f72eb9c to
d904433
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.