Type CLI worker flags so clap validates values at parse time#53
Merged
Conversation
Replace Option<String> worker fields in cli.rs with Option<bool> /
Option<u32> / Option<u64>, using value_parser ranges to enforce
positive integers. clap now rejects non-bool inputs ("yes", "1") and
zero/non-numeric counts before serve_config() runs, surfacing the
flag/env-var name in the error.
ReconciliationWorkerConfig::from_values and
DailyReviewDeliveryWorkerConfig::from_values become infallible
defaulting helpers. WorkerEnvLabels and the bespoke validation error
enums are removed since clap owns the validation surface.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace Option worker fields in cli.rs with Option / Option / Option, using value_parser ranges to enforce positive integers. clap now rejects non-bool inputs ("yes", "1") and zero/non-numeric counts before serve_config() runs, surfacing the flag/env-var name in the error.
ReconciliationWorkerConfig::from_values and
DailyReviewDeliveryWorkerConfig::from_values become infallible defaulting helpers. WorkerEnvLabels and the bespoke validation error enums are removed since clap owns the validation surface.